refactor: replace hardcoded admin flash messages with constants - #4
Open
itheCreator1 wants to merge 1 commit into
Open
refactor: replace hardcoded admin flash messages with constants#4itheCreator1 wants to merge 1 commit into
itheCreator1 wants to merge 1 commit into
Conversation
Added PRIORITY_CHANGED and DEPARTMENT_TICKET_CREATED to TICKET_MESSAGES, and replaced the three inline strings in routes/admin.js (status update, priority update, department ticket creation) with their constant equivalents. STATUS_CHANGED already existed but was unused — now wired up consistently. https://claude.ai/code/session_01Hupc9FXnBbSm7X42TVhyrs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRIORITY_CHANGEDandDEPARTMENT_TICKET_CREATEDtoTICKET_MESSAGESinconstants/messages.jsroutes/admin.js(status update, priority update, department ticket creation) with their constant equivalentsSTATUS_CHANGEDalready existed but was unused — now wired up consistentlyOriginally authored on
claude/implement-todo-item-rNrYV; rebased onto currentmain(already up to date, no conflicts) as part of a repo cleanup pass.Test plan
mainproduces no conflicts🤖 Generated with Claude Code